[webkit-reviews] review canceled: [Bug 44384] [Qt] Crash when purging the scratch buffer for the shadow : [Attachment 65036] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 21 17:04:32 PDT 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has canceled Ariya Hidayat
<ariya.hidayat at gmail.com>'s request for review:
Bug 44384: [Qt] Crash when purging the scratch buffer for the shadow
https://bugs.webkit.org/show_bug.cgi?id=44384

Attachment 65036: Patch
https://bugs.webkit.org/attachment.cgi?id=65036&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
Andreas kindly suggested on IRC that the problem is solved easier by making
ShadowBuffer a child of QCoreApplication::instance().

This leads me into thinking, maybe we should fix our shared timer instead so
that application destruction stops and closes pending timers.

Clearing the review flag while thinking about this.


More information about the webkit-reviews mailing list