[webkit-reviews] review requested: [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo : [Attachment 65028] Implement NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo [Update VI]...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 21 09:30:11 PDT 2010


adawit at kde.org has asked  for review:
Bug 34539: Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a
stub for NPN_GetAuthenticationInfo
https://bugs.webkit.org/show_bug.cgi?id=34539

Attachment 65028: Implement NPN_GetValueForURL and NPN_SetValueForURL and
NPN_GetAuthenticationInfo [Update VI]...
https://bugs.webkit.org/attachment.cgi?id=65028&action=review

------- Additional Comments from adawit at kde.org
Corrected all of the issues pointed out in the review execpt for the "type
*foo" should be "type* foo" because I cannot find where I did that and the code
passes the check-webkit-style script as well. It is entirely possibe I might
have missed it, but please point out where that is so it can get fixed...


More information about the webkit-reviews mailing list