[webkit-reviews] review granted: [Bug 44353] Do Not Copy Subversion Related Files in Inspector Build Phase : [Attachment 64990] [PATCH] Remove .svn directories

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 14:06:52 PDT 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 44353: Do Not Copy Subversion Related Files in Inspector Build Phase
https://bugs.webkit.org/show_bug.cgi?id=44353

Attachment 64990: [PATCH] Remove .svn directories
https://bugs.webkit.org/attachment.cgi?id=64990&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
WebCore/WebCore.xcodeproj/project.pbxproj:20491
+ [...]find
\"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\" -name
\".svn\" -type d | xargs rm -r\n";

I would actually use "rm -rf" here to force the deletion (unless you want the
script to complain if rm doesn't work).

r=me either way.


More information about the webkit-reviews mailing list