[webkit-reviews] review denied: [Bug 44275] Hooks IDBKeyPath with IDBObjectStorage::put. : [Attachment 64952] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 20 08:22:24 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 44275: Hooks IDBKeyPath with IDBObjectStorage::put.
https://bugs.webkit.org/show_bug.cgi?id=44275
Attachment 64952: Patch
https://bugs.webkit.org/attachment.cgi?id=64952&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKit/chromium/src/ChromiumBridge.cpp:505
+ void ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath(const
Vector<PassRefPtr<SerializedScriptValue> >& values, const String& keyPath,
Vector<PassRefPtr<IDBKey> >& keys)
RefPtr
WebCore/storage/IDBObjectStoreBackendImpl.cpp:139
+ Vector<PassRefPtr<SerializedScriptValue> > values;
s/PassRefPtr/RefPtr/
Otherwise LGTM
More information about the webkit-reviews
mailing list