[webkit-reviews] review denied: [Bug 44251] Web Inspector: add DOM breakpoints test : [Attachment 64829] Proposed patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44251: Web Inspector: add DOM breakpoints test
https://bugs.webkit.org/show_bug.cgi?id=44251

Attachment 64829: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=64829&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
LayoutTests/platform/qt/Skipped:109
 +  inspector/dom-breakpoints.html
It should be skipped on Gtk too, right?

LayoutTests/http/tests/inspector/inspector-test2.js:54
 +  InspectorTest.waitUntilPaused = function(callback)
Would be nice if we could install these methods only for tests that need them
like we currently do with console/elements/debugger... tests

LayoutTests/http/tests/inspector/inspector-test2.js:209
 +  function runTestInFrontend(initializeInspectorTest, completeTestCallId,
testFunction)
Please move it inside runTest to not confuse people that could try to invoke
this function in the inspected page.

LayoutTests/inspector/dom-breakpoints.html:20
 +	    InspectorTest.addResult("Found div element.");
This test is going to fail id debugger is not always enabled, r- for that.