[webkit-reviews] review granted: [Bug 44330] [Qt] WebKit2 needs to support touchevents : [Attachment 64948] Fixed version(review comments)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 06:04:37 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted  review:
Bug 44330: [Qt] WebKit2 needs to support touchevents
https://bugs.webkit.org/show_bug.cgi?id=44330

Attachment 64948: Fixed version(review comments)
https://bugs.webkit.org/attachment.cgi?id=64948&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:153
 +	       || event->type() == QEvent::TouchEnd
This indentation here wasnt fixed

WebKit2/UIProcess/API/qt/qgraphicswkview.h:69
 +	virtual void touchEvent(QTouchEvent* ev);
remove ev here

R=me, with the above changes.


More information about the webkit-reviews mailing list