[webkit-reviews] review granted: [Bug 44253] [EFL] Extend EFL WebView API to allow enable/disable Frame Flattening : [Attachment 64834] Implmented API for frame flattening

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 05:16:00 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has granted Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 44253: [EFL] Extend EFL WebView API to allow enable/disable Frame
Flattening
https://bugs.webkit.org/show_bug.cgi?id=44253

Attachment 64834: Implmented API for frame flattening
https://bugs.webkit.org/attachment.cgi?id=64834&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>

> +/**
> + * Get status of frame flattening.
> + *
> + * @param o view to check status
> + *
> + * @return EINA_TRUE if flattening is enabled, EINA_FALSE
> + *	      otherwise (errors, flattening disabled.
> + */

You missed close parentheses ")"

Please re-upload your patch with the above fixed, and fill "Reviewed by" with
"Antonio Gomes". Also, just set cq?. No need to re-review this.


More information about the webkit-reviews mailing list