[webkit-reviews] review denied: [Bug 44327] Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane : [Attachment 64939] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 05:07:33 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44327: Web Inspector: remove javascript breakpoint specific code from
BreakpointSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=44327

Attachment 64939: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=64939&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/BreakpointsSidebarPane.js:86
 +  WebInspector.BreakpointElement = function(breakpoint)
Please rename WebInspector.BreakpointElement => WebInspector.JSBreakpointItem.
Otherwise looks good.


More information about the webkit-reviews mailing list