[webkit-reviews] review denied: [Bug 44174] Web Inspector: extract profiler-related code and data from InspectorController into ProfilerAgent : [Attachment 64857] This time, interactive_ui_tests pass

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 44174: Web Inspector: extract profiler-related code and data from
InspectorController into ProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=44174

Attachment 64857: This time, interactive_ui_tests pass
https://bugs.webkit.org/attachment.cgi?id=64857&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorController.cpp:177
 +	// Needed for 'console.profile' to work.
This seems wrong. JSC does not require this for console.profile to work?

WebCore/inspector/InspectorController.cpp:506
 +	String profilerEnabledSetting = setting(profilerEnabledSettingName);
we should not perform this check in case profiler is always enabled?

WebCore/inspector/InspectorProfilerAgent.h:64
 +	void setRemoteFrontend(RemoteInspectorFrontend* frontend) {
m_remoteFrontend = frontend; }
By the nature of your agent, all the calls to it should be of query form
(initiated from the front-end side). You should not need remoteFrontend
reference for it to work.