[webkit-reviews] review canceled: [Bug 41832] [DRT] DRT should be able to dump document markers. : [Attachment 61763] A possible fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 02:35:07 PDT 2010


Hironori Bono <hbono at chromium.org> has canceled Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 41832: [DRT] DRT should be able to dump document markers.
https://bugs.webkit.org/show_bug.cgi?id=41832

Attachment 61763: A possible fix
https://bugs.webkit.org/attachment.cgi?id=61763&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Morita-san,

Thank you for your comment and sorry for my slow update.

> +- (BOOL)hasSpellingMarker:(int)location length:(int)length;
If this is for testing purpose, how about to declare this in WebFrameInternal.h
?

This function is used from TextInputController.m, i.e. outside of WebKit. So,
I'm wondering if we can put this function in WebFrameInternal.h. (I need a
comment from WebKit experts, though.)

By the way, I have updated my change to make it more compliant with the WebKit
coding style. It is definitely helpful to give me your comments.

Regards,

Hironori Bono


More information about the webkit-reviews mailing list