[webkit-reviews] review denied: [Bug 44236] GTK port doesnt compile with video turned off : [Attachment 64824] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 01:49:03 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has denied zaheer <zaheer.mot at gmail.com>'s
request for review:
Bug 44236: GTK port doesnt compile with video turned off
https://bugs.webkit.org/show_bug.cgi?id=44236

Attachment 64824: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=64824&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
This is not enough, you also need to disable the generation of the API files.
Check in the main GNUMakefile.am how the geolocation stuff is made conditional.


Also, I think the preferred style for conditional headers is to put them after
all the unconditional ones.


More information about the webkit-reviews mailing list