[webkit-reviews] review requested: [Bug 40886] Web Inspector: Backend Should Provide Full Supported CSS Properties List : [Attachment 64933] [PATCH] List Generated on Backend

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 40886: Web Inspector: Backend Should Provide Full Supported CSS Properties
List
https://bugs.webkit.org/show_bug.cgi?id=40886

Attachment 64933: [PATCH] List Generated on Backend
https://bugs.webkit.org/attachment.cgi?id=64933&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> This should not be defined in a front-end host. [...] What you really
> need is to fetch the actual list of properties from the inspected side.
> 
> ScriptArray will soon go away. [...]

Done by rebasing.

> WebCore/inspector/front-end/CSSCompletions.js:3
>  +  WebInspector.CSSCompletions.startsWith = function(prefix)
> Nit: When did we get this file... I think we should merge it with
CSSStyleModel!

Hmm, I didn't address this yet. I think CSSCompletions, being
a special array is a bad idea (it required me to individually
copy over elements). I think this "special array" concept should
be removed, and it can be merged into CSSStyleModel as a
separate patch.

-----

Maybe, instead of "fetching it" from the Frontend, it should just be an
automatic
[notify] from the backend once the frontend is connected? Let me know what
you think about that idea.