[webkit-reviews] review granted: [Bug 44129] Crash in WebCore::Node::createRendererIfNeeded() : [Attachment 64926] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 23:00:38 PDT 2010


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 44129: Crash in WebCore::Node::createRendererIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=44129

Attachment 64926: Patch
https://bugs.webkit.org/attachment.cgi?id=64926&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Very nice.  Thanks for writing this patch.  It pays off a debt we incurred.

WebCore/html/HTMLTreeBuilder.cpp:1825
 +		if (lastNode->element()->parentElement()->attached() &&
!lastNode->element()->attached())
I would have temporaries for these, but ok.


More information about the webkit-reviews mailing list