[webkit-reviews] review granted: [Bug 44190] [Cairo] Eliminate full-surface copy from canvas.drawImage(...) : [Attachment 64742] Patch for this issue

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 44190: [Cairo] Eliminate full-surface copy from canvas.drawImage(...)
https://bugs.webkit.org/show_bug.cgi?id=44190

Attachment 64742: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=64742&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:42
 +  #include <cmath>
Can you use <wtf/MathExtras.h> here? Think it's better to use the same math
include all over WebKit (Also if you want to replace cmath with another
math-lib for what ever reason).

WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:111
 +  void ImageBuffer::clip(GraphicsContext* context, const FloatRect& rect)
const
Why did you add the variable names? As long as we don't implement clip, we
should leave them out.

Patch looks great. Please change the snippets. r=me.