[webkit-reviews] review denied: [Bug 43989] There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle : [Attachment 64919] added nested case and expected results

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 43989: There is no test for unicode-bidi / direction support in
ApplyStyleCommand::applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=43989

Attachment 64919: added nested case and expected results
https://bugs.webkit.org/attachment.cgi?id=64919&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> Index:
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt
> +FAIL Natural on third word of "<span dir="rtl">hello <span dir="ltr">world
webkit rocks</span></span>" yielded <span dir="rtl">hello <span
dir="ltr">world</span></span><span><span> webkit</span></span><span
dir="rtl"><span dir="ltr"> rocks</span></span> but expected <span
dir="rtl">hello <span dir="ltr">world</span></span> webkit<span dir="rtl"><span
dir="ltr"> rocks</span></span>
> +FAIL LeftToRight on third word of "<span dir="rtl">hello <span
dir="ltr">world webkit rocks</span></span>" yielded <span dir="rtl">hello <span
dir="ltr">world</span></span><span><span><span style="unicode-bidi: embed;">
webkit</span></span></span><span dir="rtl"><span dir="ltr"> rocks</span></span>
but expected <span dir="rtl">hello <span dir="ltr">world</span></span><span
style="unicode-bidi: embed;"> webkit</span><span dir="rtl"><span dir="ltr">
rocks</span></span>

These tests are expected to fail?  Can you include a link to a bug for these
failing tests?

> Index:
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js
> +function modifyWritingDirection(content, selector, command, expected)
> +{
> +    if (!window.layoutTestController)
> +	   return;

Is this redundant with the earlier check (line 3)?

> +    var selected = selector(testContainer);
> +   
window.layoutTestController.execCommand('MakeTextWritingDirection'+command);

Nit: Spaces around the +