[webkit-reviews] review canceled: [Bug 44288] MarkupAccumulator::appendStartMarkup should be broken down into pieces : [Attachment 64897] cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 19 14:56:54 PDT 2010
Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 44288: MarkupAccumulator::appendStartMarkup should be broken down into
pieces
https://bugs.webkit.org/show_bug.cgi?id=44288
Attachment 64897: cleanup
https://bugs.webkit.org/attachment.cgi?id=64897&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #5)
> (From update of attachment 64897 [details])
> Thanks for working on this code. It's blowing my mind too much to review
properly.
>
> WebCore/ChangeLog:14
> + No new tests. (OOPS!)
> This can't land with OOPS
Sorry, I meant to change that line to "No new tests are added since this is a
cleanup." Fixed.
(In reply to comment #6)
> If you're going to do a lot of work on markup.cpp, please consider cleaning
up all the style in a first pass.
Which function / part of code are you referring to?
More information about the webkit-reviews
mailing list