[webkit-reviews] review granted: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63939] Part 4: FullScreen-WebCore-CSS

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 63939: Part 4: FullScreen-WebCore-CSS
https://bugs.webkit.org/attachment.cgi?id=63939&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> @@ -553,6 +553,14 @@ static void loadFullDefaultStyle()
>      String quirksRules = String(quirksUserAgentStyleSheet,
sizeof(quirksUserAgentStyleSheet)) +
RenderTheme::defaultTheme()->extraQuirksStyleSheet();
>      CSSStyleSheet* quirksSheet = parseUASheet(quirksRules);
>      defaultQuirksStyle->addRulesFromSheet(quirksSheet, screenEval());
> +    
> +#if ENABLE(FULLSCREEN_API)
> +    // Full-screen rules.
> +    String fullscreenRules = String(fullscreenUserAgentStyleSheet,
sizeof(fullscreenUserAgentStyleSheet)) +
RenderTheme::defaultTheme()->extraDefaultStyleSheet();
> +    CSSStyleSheet* fullscreenSheet = parseUASheet(fullscreenRules);
> +    defaultStyle->addRulesFromSheet(fullscreenSheet, screenEval());
> +    defaultQuirksStyle->addRulesFromSheet(fullscreenSheet, screenEval());
> +#endif

All of the other style sheets added for optionally compiled features are added
in CSSStyleSelector::styleForElement. Is there a reason to load this in
loadFullDefaultStyle instead?

> +	       case CSSSelector::PseudoFullScreen:
> +		   // While a Document is in the fullscreen state, and the
document's current fullscreen 
> +		   // element is an element in the document, the 'full-screen'
pseudoclass applies to 
> +		   // that element. Also, an <iframe>, <object> or <embed>
element whose child browsing 
> +		   // context's Document is in the fullscreen state has the
'full-screen' pseudoclass applied.
> +		   if (!e->document()->webkitFullScreen())
> +		       return false;
> +		   if (e != e->document()->webkitCurrentFullScreenElement())
> +		       return false;

Is the "... an <iframe>, <object> or <embed> element whose child browsing
context's ..." comment specifically relevant here?

r=me if you address these comments.