[webkit-reviews] review granted: [Bug 44202] Implement strict type checking in js bindings for WebGL functions : [Attachment 64871] revised patch: fixing the error in the comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 19 11:38:24 PDT 2010
Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 44202: Implement strict type checking in js bindings for WebGL functions
https://bugs.webkit.org/show_bug.cgi?id=44202
Attachment 64871: revised patch: fixing the error in the comment
https://bugs.webkit.org/attachment.cgi?id=64871&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine. Minor grammatical comments, not strictly necessary to fix.
WebCore/bindings/scripts/CodeGeneratorJS.pm:1967
+ # an TypeError is thrown instead of casting to
null.
an -> a
WebCore/bindings/scripts/CodeGeneratorV8.pm:1249
+ # an TypeError is thrown instead of casting to null.
an -> a
More information about the webkit-reviews
mailing list