[webkit-reviews] review granted: [Bug 44268] build-webkittestrunner doesn't build TestNetscapePlugIn on Windows : [Attachment 64859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 09:24:32 PDT 2010


Sam Weinig <sam at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 44268: build-webkittestrunner doesn't build TestNetscapePlugIn on Windows
https://bugs.webkit.org/show_bug.cgi?id=44268

Attachment 64859: Patch
https://bugs.webkit.org/attachment.cgi?id=64859&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
It also doesn't do it on the Mac. I think we should eventually move
TestNetscapePlugin, ImageDiff and DumpRenderTreeSupport into their own
projects, but if we wanted to fix this on the mac, we could just have
build-webkittestrunner script build those targets in the DumpRenderTree
project.

r=me.


More information about the webkit-reviews mailing list