[webkit-reviews] review granted: [Bug 44164] Implement persistance for IndexedDB ObjectStores : [Attachment 64831] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 07:12:51 PDT 2010


Steve Block <steveblock at google.com> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 44164: Implement persistance for IndexedDB ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=44164

Attachment 64831: Patch
https://bugs.webkit.org/attachment.cgi?id=64831&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
WebCore/storage/IDBObjectStoreBackendImpl.cpp:83
 +  static int bindKey(SQLiteStatement& query, int column, IDBKey* key)
I'm not sure it makes much sense for this to be a separate method

WebCore/storage/IDBObjectStoreBackendImpl.cpp:101
 +  static void bindWhereClause(SQLiteStatement& query, int64_t id, IDBKey*
key)
Nice. Is bindWhereClauseStatement() more clear?


More information about the webkit-reviews mailing list