[webkit-reviews] review requested: [Bug 38424] add support for text/html-sandboxed on sandboxed iframes : [Attachment 64832] Updated patch with more tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 05:25:23 PDT 2010


Patrik Persson <patrik.j.persson at ericsson.com> has asked  for review:
Bug 38424: add support for text/html-sandboxed on sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=38424

Attachment 64832: Updated patch with more tests
https://bugs.webkit.org/attachment.cgi?id=64832&action=review

------- Additional Comments from Patrik Persson <patrik.j.persson at ericsson.com>
(In reply to comment #5)
> What is ENABLE(SANDBOX) ?  I don't think we should have an ENABLE for this
feature.  It's not that complicated.

This flag was introduced in bug 35147.

> Please test loading in the main frame, as well as an object tag.

We have now added tests for 'text/html-sandboxed' documents in popup windows
and object tags. The WebCore aspects of the patch remain unchanged.


More information about the webkit-reviews mailing list