[webkit-reviews] review granted: [Bug 40793] [Cairo] The size of the shadow image uses the standard deviation size instead of the blur radius : [Attachment 64823] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 40793: [Cairo] The size of the shadow image uses the standard deviation
size instead of the blur radius
https://bugs.webkit.org/show_bug.cgi?id=40793

Attachment 64823: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=64823&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:931
 +	sd = FEGaussianBlur::calculateStdDeviation(radius);
avoid the new line, just:
float sd = FEGaussianBlur::calculateStdDeviation(radius);

WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:934
 +	if (!radius || (!sd)) {
avoid the braces arround !sd

WebCore/platform/graphics/filters/FEGaussianBlur.cpp:203
 +  float FEGaussianBlur::calculateStdDeviation(const float& radius)
No need for const float& . We usally just use float for normal floats.

WebCore/platform/graphics/filters/FEGaussianBlur.h:46
 +	static float calculateStdDeviation(const float& radius);
make it const please.

Small changes. But please fix them before landing. r=me