[webkit-reviews] review granted: [Bug 44229] Range, EAnnotateForInterchange, and EAbsoluteURLs should be member variables of MarkupAccumulator : [Attachment 64807] cleanup

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 44229: Range, EAnnotateForInterchange, and EAbsoluteURLs should be member
variables of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=44229

Attachment 64807: cleanup
https://bugs.webkit.org/attachment.cgi?id=64807&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    inline bool shouldResolveURLs() { return m_shouldResolveURLs ==
AbsoluteURLs; }
> +    inline bool shouldAnnotate() { return m_shouldAnnotate ==
AnnotateForInterchange; }

No need for the inline keyword here. All function bodies in a class definition
are treated as if marked within line.

> +    const Range* m_range;

Since you're doing all the const, this could be const Range* const to make it
clear that the range pointer is also constant. Not that I think the const is
all that helpful.

r=me