[webkit-reviews] review granted: [Bug 43151] [chromium] Add WebKit API for HTML5 FileSystem API : [Attachment 64797] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 18 22:14:15 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 43151: [chromium] Add WebKit API for HTML5 FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=43151
Attachment 64797: Patch
https://bugs.webkit.org/attachment.cgi?id=64797&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebFrameClient.h:46
+ class WebFileSystemCallbacks;
nit: this is also forward declared in WebFileSystem.h, so you don't
need it here.
note, your comment about FileEntry not corresponding to a directory in
the spec makes me reconsider my previous suggestion of changing
WebFileSystemEntry to WebFileEntry. maybe your original name was
better.
More information about the webkit-reviews
mailing list