[webkit-reviews] review granted: [Bug 44215] Add ability to set custom userAgent for WebKit2 : [Attachment 64786] Patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 44215: Add ability to set custom userAgent for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44215

Attachment 64786: Patch
https://bugs.webkit.org/attachment.cgi?id=64786&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
 +String WebPage::userAgent()
> +{
> +    if (!m_customUserAgent.isNull())
> +	   return m_customUserAgent;
> +
> +    // FIXME: This should be based on an application name.
> +    return  "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6; en-us)
AppleWebKit/531.4 (KHTML, like Gecko) Version/4.0.3 Safari/531.4";

Extra space after return.

> @@ -92,6 +92,7 @@ public:
>      // -- Called from WebCore clients.
>      bool handleEditingKeyboardEvent(WebCore::KeyboardEvent*);
>      void show();
> +    String userAgent();

Looks like this could be const.

r=me