[webkit-reviews] review granted: [Bug 39474] [GStreamer] GTK XOverlay support in GStreamerGWorld : [Attachment 64717] fullscreen video support in WebKit/gtk

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 39474: [GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474

Attachment 64717: fullscreen video support in WebKit/gtk
https://bugs.webkit.org/attachment.cgi?id=64717&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h:46
 +	    gulong m_videoWindowId;
Is gulong portable enough? Should we use a typedef similar to the
PlatformWindowType here?

 418	 void webkit_web_view_enter_fullscreen(WebKitWebView* webView,
WebCore::Node* node);
 419	 void webkit_web_view_exit_fullscreen(WebKitWebView* webView);

Make these follow the standard WebKit naming, since they are not really API, I
think. webkitWebViewEnterFullscreen, for instance.

WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:298
 +  
Needless empty line.

WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:590
 +  
One more needless empty line =).

Looks good to me, thanks for clarifying the GClosure point, btw, let's get this
thing on the wild!