[webkit-reviews] review requested: [Bug 37880] [Qt] Patch for checking the content-type supported by the QWebFrame... : [Attachment 64781] Function for checking content-type supported by QWebFrame III...

[bugzilla-daemon at webkit.org]

adawit at kde.org has asked  for review:
Bug 37880: [Qt] Patch for checking the content-type supported by the
QWebFrame...
https://bugs.webkit.org/show_bug.cgi?id=37880

Attachment 64781: Function for checking content-type supported by QWebFrame
III...
https://bugs.webkit.org/attachment.cgi?id=64781&action=review

------- Additional Comments from adawit at kde.org
Fixed all the issues pointed out by the reviews. Also renamed
"isSupportedContentType(xxx)" to "canHandleMimeType(xxx)".

I also wonder whether or not there should be some mechanism to prevent QtWebKit
from handling certain mimetypes.
For example, by default QtWebKit (read: webkit) handles all "text/" mime-types.
However, in places where such
option is configurable, e.g. KDE, there is no way to prevent QtWebKit from
doing this. In fact, a bug report has already
been filed against kwebkit about this very same issue. See
https://bugs.kde.org/show_bug.cgi?id=242417.