[webkit-reviews] review granted: [Bug 43871] [chromium] Chromium side implementation of blob data and blob registry : [Attachment 64774] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jian Li
<jianli at chromium.org>'s request for review:
Bug 43871: [chromium] Chromium side implementation of blob data and blob
registry
https://bugs.webkit.org/show_bug.cgi?id=43871

Attachment 64774: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=64774&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebBlobStorageData.h:49
 +	struct Item {
how about reusing WebBlobData::Item here?  either with a using
directive or just by typing WebBlobData::Item in place of Item.

WebKit/chromium/public/WebKitClient.h:95
 +	virtual WebBlobRegistry* blobRegistry() { return 0; }
please add a comment indicating if it is OK for a client to return null.
this impacts whether or not the webkit code should null test blobRegistry
before calling methods on it.

WebKit/chromium/public/WebBlobData.h:55
 +	    WebFileInfo fileInfo;
i'm concerned that we will need to add more things to WebFileInfo
in the future to support WebFileSystem::getMetadata.  you may only
want to have a timestamp here.

R=me otherwise