[webkit-reviews] review denied: [Bug 43449] [chromium] Generate drag images for HTML elements and selections. : [Attachment 64768] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 18 14:08:22 PDT 2010
Daniel Cheng <dcheng at chromium.org> has denied review:
Bug 43449: [chromium] Generate drag images for HTML elements and selections.
https://bugs.webkit.org/show_bug.cgi?id=43449
Attachment 64768: Patch
https://bugs.webkit.org/attachment.cgi?id=64768&action=review
------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
Per jamesr comments, I need to add a check for ImageBuffer::create failure.
For what it's worth, I'm saving the various bits that I twiddle in the view,
because that's what other ports have done in their nodeImage implementations. I
tried leaving it out once, which resulted in rather interesting painting
results, so I think it's required.
More information about the webkit-reviews
mailing list