[webkit-reviews] review denied: [Bug 33852] Implement HTMLVideoElement support for texImage2D and texSubImage2D : [Attachment 64748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 13:35:27 PDT 2010


Chris Marrin <cmarrin at apple.com> has denied Adrienne Walker <enne at google.com>'s
request for review:
Bug 33852: Implement HTMLVideoElement support for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=33852

Attachment 64748: Patch
https://bugs.webkit.org/attachment.cgi?id=64748&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
WebCore/html/canvas/WebGLRenderingContext.cpp:2484
 +	texSubImage2DImpl(target, level, xoffset, yoffset, format, type,
buf->image(), m_unpackFlipY, m_unpackPremultiplyAlpha, ec);


You need to update your patch to take into account Dave Hyatt's recent change
to ImageBuffer where he gets rid of ImageBuffer::image. There is a new way to
do this now, but I'm not sure what it is.


More information about the webkit-reviews mailing list