[webkit-reviews] review requested: [Bug 41364] [Qt] QWebPage::allowGeolocationRequest should be async API : [Attachment 64756] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 12:32:53 PDT 2010


Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has asked  for review:
Bug 41364: [Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Attachment 64756: patch
https://bugs.webkit.org/attachment.cgi?id=64756&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
This patch includes changes described in comment 4 and comment 5 and   

1) cache client permission from call QWebPage::setUserPermission() even without
any geolocation requests. When Webcore makes a geolocation permission request,
cached permission will be passed on. This way clients can set default sync
permission to geolocation. 

2) Enabled all geolocation delayed layout test cases to Qt port as the
permission API is now async

Please review


More information about the webkit-reviews mailing list