[webkit-reviews] review denied: [Bug 38424] add support for text/html-sandboxed on sandboxed iframes : [Attachment 64699] Patch including Changelog entries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 11:06:27 PDT 2010


Adam Barth <abarth at webkit.org> has denied Patrik Persson
<patrik.j.persson at ericsson.com>'s request for review:
Bug 38424: add support for text/html-sandboxed on sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=38424

Attachment 64699: Patch including Changelog entries
https://bugs.webkit.org/attachment.cgi?id=64699&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/DOMImplementation.cpp:291
 +  #if ENABLE(SANDBOX)
What is ENABLE(SANDBOX) ?  I don't think we should have an ENABLE for this
feature.  It's not that complicated.

Please test loading in the main frame, as well as an object tag.


More information about the webkit-reviews mailing list