[webkit-reviews] review granted: [Bug 44180] WebView::paint fails to paint a child WebView of a Layered Window : [Attachment 64724] Check if m_backingStoreBitmap is null instead of whether rcPaint is empty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 10:36:11 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 44180: WebView::paint fails to paint a child WebView of a Layered Window
https://bugs.webkit.org/show_bug.cgi?id=44180

Attachment 64724: Check if m_backingStoreBitmap is null instead of whether
rcPaint is empty
https://bugs.webkit.org/attachment.cgi?id=64724&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    bool backingStoreCompletelyDirty = ensureBackingStore();
> +    if (!m_backingStoreBitmap) {
> +	   EndPaint(m_viewWindow, &ps);
>	   return;
>      }

We should only call EndPaint if a dc was passed to this function. Otherwise we
won't have called BeginPaint.

r=me


More information about the webkit-reviews mailing list