[webkit-reviews] review granted: [Bug 44184] CanvasStyle method naming cleanup : [Attachment 64722] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 18 10:21:33 PDT 2010
Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 44184: CanvasStyle method naming cleanup
https://bugs.webkit.org/show_bug.cgi?id=44184
Attachment 64722: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=64722&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + static PassRefPtr<CanvasStyle>
createFromGradient(PassRefPtr<CanvasGradient> gradient);
> + static PassRefPtr<CanvasStyle>
createFromPattern(PassRefPtr<CanvasPattern> pattern);
No need for argument names in these two functions, since the type already
expresses the name of the argument.
More information about the webkit-reviews
mailing list