[webkit-reviews] review requested: [Bug 37880] [Qt] Patch for checking the content-type supported by the QWebFrame... : [Attachment 64726] Function for checking content-type supported by QWebFrame II...

[bugzilla-daemon at webkit.org]

adawit at kde.org has asked  for review:
Bug 37880: [Qt] Patch for checking the content-type supported by the
QWebFrame...
https://bugs.webkit.org/show_bug.cgi?id=37880

Attachment 64726: Function for checking content-type supported by QWebFrame
II...
https://bugs.webkit.org/attachment.cgi?id=64726&action=review

------- Additional Comments from adawit at kde.org
Updated patch:

* Changed the function name to isSupportedContentType.
* Added a new function, supportedContentTypes() to return all supported content
types.

@simon: I cannot make these functions static because I will not be able to
access the frame's local QWebSettings (d->frame->settings()) to
obtain the mimetypes supported by any uploaded plugins just like in
FrameLoaderClientQt::canShowMIMEType. Also, you did not say which class these
functions might belong to other than where they are, QWebSettings, QWebPage ??
Once these issues are resolved, I can provide unit test cases for these
function.