[webkit-reviews] review denied: [Bug 44174] Web Inspector: extract profiler-related code and data from InspectorController into ProfilerAgent : [Attachment 64712] Fix mac linking issue

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 44174: Web Inspector: extract profiler-related code and data from
InspectorController into ProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=44174

Attachment 64712: Fix mac linking issue
https://bugs.webkit.org/attachment.cgi?id=64712&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/GNUmakefile.am:1628
 +	WebCore/inspector/InspectorProfilerAgent.cpp \
Do not forget the CMakeLists.

WebCore/ChangeLog:5
 +	    Extract profiler-related code and data from InspectorController
into ProfilerAgent.
Web Inspector: Extract ... into InspectorProfilerAgent.

WebCore/inspector/InspectorController.cpp:1488
 +	if (profilerEnabled())
In the previous version, user initiated profiling could be started regardless
of the profilerEnabled state. You should not change that. r- for that. Please
make sure profiler tests are passing!