[webkit-reviews] review denied: [Bug 44158] [soup] implement ResourceHandle::platformSetDefersLoading : [Attachment 64680] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 44158: [soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158

Attachment 64680: proposed patch
https://bugs.webkit.org/attachment.cgi?id=64680&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
I think this is a good thing to have, since other platforms support it, but do
we have an idea of what this gains us? Is there a way to test it? It looks like
we want to also check whether the message should start deferred: the
constructor has a boolean: ResourceHandle(const ResourceRequest&,
ResourceHandleClient*, bool defersLoading, bool shouldContentSniff);. Mac
checks m_defersLoading when a new message is queued, and pauses it, it seems.
I'll say r- for the lack of checking if we should start deferred, but it would
be great if we could know why we are implementing this before we do.