[webkit-reviews] review granted: [Bug 44101] [IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution. : [Attachment 64709] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 44101: [IndexedDB] Abort idle IDBTransactions when the JS context they were
created in finishes execution.
https://bugs.webkit.org/show_bug.cgi?id=44101

Attachment 64709: Patch
https://bugs.webkit.org/attachment.cgi?id=64709&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKit/chromium/src/WebIDBTransactionImpl.h:54
 +  
extra newline

WebCore/storage/IDBPendingTransactionMonitor.cpp:37
 +	return (m_ids && m_ids->size());
no need for ()'s

WebCore/storage/IDBPendingTransactionMonitor.cpp:58
 +	m_ids->clear();
Hm...might be worth to have this do a if (m_ids) check?

WebCore/storage/IDBPendingTransactionMonitor.cpp:47
 +  void IDBPendingTransactionMonitor::removePendingTransaction(int id)
I'm tempted to say this should be a set rather than a vector...but at the same
time I don't see the list ever getting very big.

WebCore/storage/IDBPendingTransactionMonitor.h:51
 +	static const Vector<int>& pendingTransactions();
newline after

WebCore/storage/IDBTransactionCoordinator.cpp:1
 +  #include "config.h"
license!


r=me