[webkit-reviews] review granted: [Bug 42886] Web Inspector: implement DOM breakpoints : [Attachment 64707] After offline discussion.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 07:48:37 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 42886: Web Inspector: implement DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=42886

Attachment 64707: After offline discussion.
https://bugs.webkit.org/attachment.cgi?id=64707&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorDOMAgent.cpp:1039
 +  void InspectorDOMAgent::updateSubtreeBreakpoints(Node* root, long mask,
bool value, bool wholeSubtree)
Nit:
wholeSubtree -> recursive
value -> set


More information about the webkit-reviews mailing list