[webkit-reviews] review granted: [Bug 43882] [Qt] Move the accelerated compositing build flag to the right place : [Attachment 64676] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 43882: [Qt] Move the accelerated compositing build flag to the right place
https://bugs.webkit.org/show_bug.cgi?id=43882

Attachment 64676: Patch
https://bugs.webkit.org/attachment.cgi?id=64676&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Noam, the patch looks good. One major comment below though.

>  2010-08-17  Gavin Barraclough  <barraclough at apple.com>
>  
>	   Reviewed by Sam Weinig.
> diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h
> index
f653adb2c0a59e6add35b821d1ec139a2c38583a..78968a900d12df7728f1b258a9c546ab1d9ea
2e5 100644
> --- a/JavaScriptCore/wtf/Platform.h
> +++ b/JavaScriptCore/wtf/Platform.h
> @@ -1052,7 +1052,7 @@ on MinGW. See
https://bugs.webkit.org/show_bug.cgi?id=29268 */
>  #define WTF_USE_ACCELERATED_COMPOSITING 1
>  #endif
>  
> -#if PLATFORM(QT)
> +#if PLATFORM(QT) && !(defined(QT_VERSION) && QT_VERSION < 0x040600) &&
!defined(WTF_USE_ACCELERATED_COMPOSITING)
>  #define WTF_USE_ACCELERATED_COMPOSITING 1
>  #endif

in bug 43695, we moved away from using the  encoded hex for qt version check.
could you keep the consistency?

The rest is fine.