[webkit-reviews] review denied: [Bug 42027] [Qt] Request for permission before starting Geolocation service : [Attachment 64678] patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42027: [Qt] Request for permission before starting Geolocation service
https://bugs.webkit.org/show_bug.cgi?id=42027

Attachment 64678: patch
https://bugs.webkit.org/attachment.cgi?id=64678&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
WebCore/ChangeLog:13
 +	    Delayed layout cases for this bug are skipped for Qt (bug #41364
will fix)
It would be good if you could explicitly list the existing tests that test this
code, as in theory, it's not specific to Qt.

WebCore/page/Geolocation.cpp:701
 +		   
notifier->setFatalError(PositionError::create(PositionError::POSITION_UNAVAILAB
LE, failedToStartServiceErrorMessage));
Nice. Can't we now also remove the CLIENT_BASED_GEOLOCATION early-out above?