[webkit-reviews] review granted: [Bug 44009] Use SVGPathParser logic to traverse states of a Path : [Attachment 64488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 01:19:51 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 44009: Use SVGPathParser logic to traverse states of a Path
https://bugs.webkit.org/show_bug.cgi?id=44009

Attachment 64488: Patch
https://bugs.webkit.org/attachment.cgi?id=64488&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r=me, with two small suggestions:

WebCore/ChangeLog:8
 +	    Move the getPathsegAtLength logic from SVGPathSegList into a new
SVGPathConsumer
s/Pathseg/PathSeg/

WebCore/svg/SVGPathTraversalStateBuilder.h:35
 +	unsigned long getSVGPathSeg();
s/getSVGPathSeg/pathSegmentIndex/


More information about the webkit-reviews mailing list