[webkit-reviews] review requested: [Bug 42027] [Qt] Request for permission before starting Geolocation service : [Attachment 64673] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 00:15:32 PDT 2010


Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has asked  for review:
Bug 42027: [Qt] Request for permission before starting Geolocation service
https://bugs.webkit.org/show_bug.cgi?id=42027

Attachment 64673: patch
https://bugs.webkit.org/attachment.cgi?id=64673&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
Fixes,

1) Starting location service when request is granted for ports using
!CLIENT_BASED_GEOLOCATION and PREEMPT_GEOLOCATION_PERMISSION
2) Enables PREEMPT_GEOLOCATION_PERMISSION for QtWebkit

No new cases added as I'm not sure if there is a way GeolocationServiceMock can
have PREEMPT_GEOLOCATION_PERMISSION enabled?


More information about the webkit-reviews mailing list