[webkit-reviews] review denied: [Bug 44112] Web Inspector: activate/deactivate breakpoints using v8 debugger flag : [Attachment 64597] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 22:42:06 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44112: Web Inspector: activate/deactivate breakpoints using v8 debugger
flag
https://bugs.webkit.org/show_bug.cgi?id=44112

Attachment 64597: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=64597&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/js/DebuggerScript.js:200
 +	Debug.debuggerFlags().breakPointsActive.setValue(args.enabled);
Breakpoints are always activated in the frontend when it's just launched. With
this code we may deactivate breakpoints, then close frontend, reopen frontend
and get an inconsistent state of the flag in the debugger script and frontend.
Please fix this.


More information about the webkit-reviews mailing list