[webkit-reviews] review granted: [Bug 44147] [EFL] enable libsoup's content decode feature : [Attachment 64661] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 44147: [EFL] enable libsoup's content decode feature
https://bugs.webkit.org/show_bug.cgi?id=44147

Attachment 64661: Patch
https://bugs.webkit.org/attachment.cgi?id=64661&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
r=me

> +	   [EFL] enable libsoup's content decode feature
> +	   https://bugs.webkit.org/show_bug.cgi?id=44147
> +
> +	   libsoup's content decode feature is enabled during initializaton.

Please, rephrase to something like: "Enable libsoup's content decode
feature..." or "Make libsoup's content decode feature is enabled during
initializaton to fix web sites that send CSS encoded", blablabla. Something
more descriptive.

ps: When uploading the new patch , fill "Reviewed by" statement in the
ChangeLog with "Antonio Gomes" and just set "cq?" to the patch. No need for a
new 

> --- a/WebKit/efl/ewk/ewk_main.cpp
> +++ b/WebKit/efl/ewk/ewk_main.cpp
> @@ -125,6 +125,7 @@ int ewk_init(void)
>      if (1) {
>	   SoupSession* session = WebCore::ResourceHandle::defaultSession();
>	   soup_session_add_feature_by_type(session,
SOUP_TYPE_CONTENT_SNIFFER);
> +	   soup_session_add_feature_by_type(session,
SOUP_TYPE_CONTENT_DECODER);
>      }
>  #endif  

the if (1) above made me sad! :-(