[webkit-reviews] review granted: [Bug 44143] new-run-webkit-tests: remove --show-sources option : [Attachment 64655] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 17 17:27:55 PDT 2010
David Levin <levin at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 44143: new-run-webkit-tests: remove --show-sources option
https://bugs.webkit.org/show_bug.cgi?id=44143
Attachment 64655: Patch
https://bugs.webkit.org/attachment.cgi?id=64655&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> diff --git
a/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py
b/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py
> + return port.compare_text(self._get_normalized_text(file1),
> + self._get_normalized_text(file2))
Consider fixing the alignment here.
More information about the webkit-reviews
mailing list