[webkit-reviews] review granted: [Bug 40655] Database access in worker threads results in WebKit SPI notifications being posted from worker threads : [Attachment 64654] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 17:07:41 PDT 2010


Darin Adler <darin at apple.com> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40655: Database access in worker threads results in WebKit SPI
notifications being posted from worker threads
https://bugs.webkit.org/show_bug.cgi?id=40655

Attachment 64654: patch
https://bugs.webkit.org/attachment.cgi?id=64654&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is fine, r=me

But you should remove the destructors from the .cpp files. Leave them in the
headers. I’m sorry if I wasn’t clear enough about this before. This patch
leaves them in .cpp files, which is not good enough to ensure the objects never
get destroyed. They could be destroyed!


More information about the webkit-reviews mailing list