[webkit-reviews] review denied: [Bug 40655] Database access in worker threads results in WebKit SPI notifications being posted from worker threads : [Attachment 64633] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dumitru Daniliuc <dumi at chromium.org>'s
request for review:
Bug 40655: Database access in worker threads results in WebKit SPI
notifications being posted from worker threads
https://bugs.webkit.org/show_bug.cgi?id=40655

Attachment 64633: patch
https://bugs.webkit.org/attachment.cgi?id=64633&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  class WebDatabaseTrackerClient : public WebCore::DatabaseTrackerClient {
>  public:
>      static WebDatabaseTrackerClient* sharedWebDatabaseTrackerClient();
> -    
> -    virtual ~WebDatabaseTrackerClient();
> +

> Index: WebKit/win/WebDatabaseManager.h
> ===================================================================
> --- WebKit/win/WebDatabaseManager.h	(revision 65540)
> +++ WebKit/win/WebDatabaseManager.h	(working copy)
> @@ -83,7 +83,6 @@ public:
>  
>  private:
>      WebDatabaseManager();
> -    ~WebDatabaseManager();

By removing the destructor's declaration, you are making it use the default
destructor. If you kept the declaration, but had no definition, then we'd get a
link error if someone tries to destroy the object.

You could make the destructor private, but if you leave it out entirely, the
compiler will create a default one for you.