[webkit-reviews] review denied: [Bug 44117] Add support for getting test name list json from test results server : [Attachment 64630] Proposed Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Victor Wang <victorw at chromium.org>'s
request for review:
Bug 44117: Add support for getting test name list json from test results server
https://bugs.webkit.org/show_bug.cgi?id=44117

Attachment 64630: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=64630&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
WebKitTools/ChangeLog:5
 +	    Add support to test results server for downloading json that
Nit: Add support to the test results server...

WebKitTools/ChangeLog:9
 +	    results so it includes results not only for tests failed in
Nit: results so that it includes...for tests that failed in...

WebKitTools/TestResultServer/model/jsonresults.py:437
 +		Json file with test name list only. The json format is the same

Nit: s/Json/JSON or s/Json/json

WebKitTools/TestResultServer/model/jsonresults.py:454
 +		"tests": dict.fromkeys(tests, {"results": [], "times": []})}
This is a lot of bloat just for the tests list. Can "tests" just be
tests.keys()? Does this need to be in the same format as the one stored in the
datastore?