[webkit-reviews] review denied: [Bug 43453] [chromium] The chromium API needs a WebMouseEvent class : [Attachment 64411] Adding missing files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 11:12:51 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 43453: [chromium] The chromium API needs a WebMouseEvent class
https://bugs.webkit.org/show_bug.cgi?id=43453

Attachment 64411: Adding missing files
https://bugs.webkit.org/attachment.cgi?id=64411&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebNode.h:102
 +	WEBKIT_API void addDOMEventListener(const WebString& eventType,
WebDOMEventListener* listener, bool useCapture);
nit: these should just be named add/removeEventListener to match
how they are named in the DOM specification.

WebKit/chromium/src/EventListenerWrapper.h:50
 +  class EventListenerWrapperDOM : public EventListener {
EventListenerWrapperDOM is an awkward name.  can we rename the other
one DeprecatedEventListenerWrapper, and then use EventListenerWrapper?

otherwise, LGTM


More information about the webkit-reviews mailing list